Skip to content

[Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction #11941

Open
Pearapps wants to merge 19 commits intomasterfrom
kpa/feedback-additions-1
Open

[Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction #11941
Pearapps wants to merge 19 commits intomasterfrom
kpa/feedback-additions-1

Conversation

@Pearapps
Copy link
Collaborator

@Pearapps Pearapps commented Nov 10, 2025 •
edited
Loading

Progress on: #12016

Adds in some live feedback if you are scanning the wrong side of the document for the side requested & to center the ID if it is not centered in the view frame; during document capture.

Also - this adds in some live feedback during document capture for when the id is too blurry or the distance is not correct and can be corrected.

Examples:

ID distance:

Screenshot_20251117-145630 Screenshot_20251117-145709

Focus:

Screenshot_20251119-152218 Screenshot_20251119-152236

Centering

Screenshot_20251118-123323 Screenshot_20251118-123416

Incorrect side:

Screenshot_20251118-123338 Screenshot_20251118-123356

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   2.2 MiB │   2.2 MiB │   +392 B │   4.5 MiB │   4.5 MiB │   +840 B 
     arsc │   1.1 MiB │   1.1 MiB │ +5.7 KiB │   1.1 MiB │   1.1 MiB │ +5.7 KiB 
 manifest │   2.3 KiB │   2.3 KiB │      0 B │     8 KiB │     8 KiB │      0 B 
      res │ 303.5 KiB │ 303.5 KiB │      0 B │ 457.7 KiB │ 457.7 KiB │      0 B 
   native │   7.9 MiB │   7.9 MiB │      0 B │  19.3 MiB │  19.3 MiB │      0 B 
    asset │   6.6 KiB │   7.8 KiB │ +1.2 KiB │   6.3 KiB │   7.5 KiB │ +1.2 KiB 
    other │ 107.5 KiB │ 107.5 KiB │     -4 B │ 214.9 KiB │ 214.9 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  11.5 MiB │  11.6 MiB │ +7.3 KiB │  25.5 MiB │  25.5 MiB │ +7.8 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 21289 │ 21290 │ +1 (+3 -2) 
   types │  6505 │  6505 │  0 (+0 -0) 
 classes │  5216 │  5216 │  0 (+0 -0) 
 methods │ 31840 │ 31843 │ +3 (+3 -0) 
  fields │ 18204 │ 18206 │ +2 (+3 -1) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  163 │  163 │  0         
 entries │ 3719 │ 3725 │ +6 (+6 -0)
APK 
     compressed     │    uncompressed     │                               
─────────┬──────────┼──────────┬──────────┤                               
 size    │ diff     │ size     │ diff     │ path                          
─────────┼──────────┼──────────┼──────────┼───────────────────────────────
 1.1 MiB │ +5.7 KiB │  1.1 MiB │ +5.7 KiB │ ∆ resources.arsc              
 6.9 KiB │ +1.2 KiB │  6.8 KiB │ +1.2 KiB │ ∆ assets/dexopt/baseline.prof 
 2.2 MiB │   +392 B │  4.5 MiB │   +840 B │ ∆ classes.dex                 
  26 KiB │     -5 B │ 65.3 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
 1.2 KiB │     +1 B │  1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
─────────┼──────────┼──────────┼──────────┼───────────────────────────────
 3.3 MiB │ +7.3 KiB │  5.6 MiB │ +7.8 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   21289 │ 21290 │ +1 (+3 -2) 
  
  + r8-map-id-bb677d2238985a87b17c5b6d245ae85329ea85728a57f173cf6fd79894653f85
  + reachedStateAt
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"bb677d2238985a87b17c5b6d245ae85329ea85728a57f173cf6fd79894653f85","r8-mode":"full","version":"8.13.17"}
  
  - r8-map-id-de9cb19fb322718cfd9931a491303f24a3777e037c5d037fdfb7bd559d02c9eb
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"de9cb19fb322718cfd9931a491303f24a3777e037c5d037fdfb7bd559d02c9eb","r8-mode":"full","version":"8.13.17"}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   31840 │ 31843 │ +3 (+3 -0) 
  
  + j9.g <init>(j, n, b, Integer, Boolean)
  + j9.g b(Integer) → g
  + j9.h <init>(j, n, Integer)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   18204 │ 18206 │ +2 (+3 -1) 
  
  + j9.g e: Integer
  + j9.g f: Boolean
  + j9.h d: Integer
  
  - j9.g e: Boolean
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   3719 │ 3725 │ +6 (+6 -0) 
  + string/stripe_back_of_id_not_detected
  + string/stripe_front_of_id_not_detected
  + string/stripe_move_closer
  + string/stripe_move_farther
  + string/stripe_move_id_to_center
  + string/stripe_reduce_blur

@Pearapps Pearapps changed the title [Draft] [Identity] Feedback to center ID if off center during document capture [Identity] Feedback to flip ID Document over if incorrect side is detected & center ID if off center Nov 13, 2025
@Pearapps Pearapps marked this pull request as ready for review November 13, 2025 15:47
@Pearapps Pearapps requested review from a team as code owners November 13, 2025 15:47
@Pearapps Pearapps marked this pull request as draft November 18, 2025 16:39
Pearapps and others added 3 commits November 18, 2025 11:43
@Pearapps
[Identity] Live blur/focus & distance feedback during document capture (
8241ee4 
#11993)

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitionerTest.kt

* closer and further

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitioner.kt

* Update IDDetectorTransitioner.kt

---------

Co-authored-by: Ken Ackerson <[email protected]>
update copy and such
79a8998
Update IDDetectorTransitioner.kt
9b50e4e
@Pearapps Pearapps changed the title [Identity] Feedback to flip ID Document over if incorrect side is detected & center ID if off center [Identity] Feedback to flip ID Document over if incorrect side is detected, center ID if off center, ID is too blurry, and if distance needs correction Nov 18, 2025
@Pearapps Pearapps marked this pull request as ready for review November 18, 2025 18:36
cjmisenas-stripe
cjmisenas-stripe previously requested changes Nov 26, 2025
View reviewed changes
luisv-stripe
luisv-stripe requested changes Feb 4, 2026
View reviewed changes
identity/src/main/java/com/stripe/android/identity/states/IDDetectorTransitioner.kt
!run {
val centerX = analyzerOutput.boundingBox.left + analyzerOutput.boundingBox.width / 2f
val centerY = analyzerOutput.boundingBox.top + analyzerOutput.boundingBox.height / 2f
val tol = 0.05f
Copy link
Contributor

@luisv-stripe luisv-stripe Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a constant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luisv-stripe luisv-stripe luisv-stripe requested changes

@cjmisenas-stripe cjmisenas-stripe Awaiting requested review from cjmisenas-stripe

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

identity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pearapps @cjmisenas-stripe @luisv-stripe